Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: Add News and Store channels, and missing guild props #3168

Open

Conversation

@vladfrangu
Copy link
Contributor

commented Mar 29, 2019

Please describe the changes this PR makes and why it should be merged:

This PR adds:

  • Support for the News and Store Channel types
  • Support for TextChannels and NewsChannels being able to change their type
    • Thanks Discord, very cool
  • Adds the missing properties in the guild object
    • max_members
    • max_presences
    • banner
    • description
    • vanity_url_code

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

vladfrangu added some commits Mar 29, 2019

Show resolved Hide resolved src/structures/StoreChannel.js Outdated
Show resolved Hide resolved typings/index.d.ts Outdated

vladfrangu added some commits Mar 29, 2019

@Jbforfun18

This comment was marked as off-topic.

Copy link

commented Mar 29, 2019

Stop emailing me

@izexi
Copy link
Contributor

left a comment

Same thing applies for widget_enabled and widget_channel_id which is also missing.

Show resolved Hide resolved src/structures/Guild.js Outdated
Show resolved Hide resolved src/structures/Guild.js Outdated

vladfrangu added some commits Apr 14, 2019

Show resolved Hide resolved src/structures/Guild.js Outdated
Show resolved Hide resolved typings/index.d.ts Outdated

izexi and others added some commits Apr 14, 2019

typings: afkChannel is a VC
I keep confusing them, ffs

Co-Authored-By: vladfrangu <kingdgrizzle@gmail.com>
@izexi

izexi approved these changes Apr 15, 2019

vladfrangu added some commits Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.