Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Webhook): add url getter #3178

Merged
merged 4 commits into from Apr 5, 2019

Conversation

Projects
None yet
4 participants
@izexi
Copy link
Contributor

commented Apr 4, 2019

You're able to retrieve this using the client, so it would be a nice little helper getter that the library could provide instead of having to construct this yourself.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

izexi added some commits Apr 4, 2019

Show resolved Hide resolved src/structures/Webhook.js Outdated
Show resolved Hide resolved src/structures/Webhook.js Outdated

@SpaceEEC SpaceEEC merged commit c078682 into discordjs:master Apr 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@izexi izexi deleted the izexi:Webhook-url branch Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.