Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utilize URLSearchParams #3180

Merged
merged 4 commits into from Apr 5, 2019

Conversation

Projects
None yet
4 participants
@bdistin
Copy link
Member

commented Apr 4, 2019

Please describe the changes this PR makes and why it should be merged:
This pr removes the reliance on querystring and switches to the new node global URLSearchParams (which is also a browser API). This also removes a place where the base API URL is hardcoded so that we use the constants/client.options base URL in case that's ever changed.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

bdistin added some commits Apr 4, 2019

@SpaceEEC SpaceEEC merged commit 5e9bd78 into discordjs:master Apr 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@izexi izexi referenced this pull request Apr 6, 2019

Merged

ref(WebSocket): utilize URLSearchParams #3185

2 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.