Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(WebSocket): utilize URLSearchParams #3185

Merged
merged 2 commits into from Apr 8, 2019

Conversation

Projects
None yet
2 participants
@izexi
Copy link
Contributor

commented Apr 6, 2019

#3180 removed the reliance on the querystring package by making use of URLSearchParams within the APIRequest, this PR pretty much does the same but within the WebSocket.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@SpaceEEC SpaceEEC changed the title ref(Webhook): utilize URLSearchParams ref(WebSocket): utilize URLSearchParams Apr 6, 2019

@SpaceEEC SpaceEEC merged commit 152d2e8 into discordjs:master Apr 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@izexi izexi deleted the izexi:Webhook-URLSearchParams branch Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.