Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: Fix resume event not being emitted properly #3192

Merged
merged 6 commits into from Apr 21, 2019

Conversation

Projects
None yet
3 participants
@vladfrangu
Copy link
Contributor

commented Apr 9, 2019

Please describe the changes this PR makes and why it should be merged:

Per #3191, the resumed event was not properly being emitted. This PR solves this, and closes #3191.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

vladfrangu added some commits Apr 9, 2019

stale

@xonrsoftware

This comment has been minimized.

Copy link

commented Apr 21, 2019

Several bots staying up for already six days.
Seems like bd8ac4d fixed silent disconnect issue.

@SpaceEEC SpaceEEC merged commit 1514df0 into discordjs:master Apr 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.