Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Presence): add ClientPresenceStatus typedef #3208

Merged
merged 1 commit into from Apr 15, 2019

Conversation

Projects
None yet
2 participants
@izexi
Copy link
Contributor

commented Apr 15, 2019

This PR partially reverts 4ac9c5d, since the types were correct before as Presence#clientStatus doesn't include the "offline" status and adds a ClientPresenceStatus typedef (which excludes "offline" from the PresenceStatus's typedef) to match the typings.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
@SpaceEEC
Copy link
Member

left a comment

We are getting there.

@SpaceEEC SpaceEEC merged commit d9a053d into discordjs:master Apr 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@izexi izexi deleted the izexi:ClientPresenceStatus branch Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.