Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Actions): use partials for MessageDeleteBulk #3240

Merged
merged 3 commits into from May 3, 2019

Conversation

Projects
None yet
3 participants
@izexi
Copy link
Contributor

commented Apr 29, 2019

Make use of partials for the MessageDeleteBulk event. Although it doesn't provide much use as for retrieving accurate properties of the messages (such as the content) as you can't fetch a message that was deleted for obvious reasons, it should allow developers to monitor the messageDeleteBulk event for uncached messages.

The cache param on DataStore.add(...) will be set to false for this since the message will immediately be deleted anyways, so it would be a bit redundant to cache the messages.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@SpaceEEC SpaceEEC merged commit 176fc47 into discordjs:master May 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@izexi izexi deleted the izexi:MessageDeleteBulk-partials branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.