feat(Actions): use partials for MessageDeleteBulk #3240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpaceEEC
approved these changes
May 3, 2019
samsamson33
pushed a commit
to samsamson33/discord.js
that referenced
this pull request
Feb 27, 2020
* make use of partials * don't cache the messages * pass each message within the for..of iteration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of partials for the MessageDeleteBulk event. Although it doesn't provide much use as for retrieving accurate properties of the messages (such as the content) as you can't fetch a message that was deleted for obvious reasons, it should allow developers to monitor the messageDeleteBulk event for uncached messages.
The
cacheparam on DataStore.add(...) will be set tofalsefor this since the message will immediately be deleted anyways, so it would be a bit redundant to cache the messages.Status
Semantic versioning classification: