Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Util.escapeMarkdown) #3241

Merged
merged 11 commits into from Jul 11, 2019

Conversation

Projects
None yet
5 participants
@bdistin
Copy link
Member

commented Apr 29, 2019

Please describe the changes this PR makes and why it should be merged:
This makes escapeMarkdown more robust by separating all of the options, and ways it can be used. This also combines all of the options into a single options object as per our repo guideline.

Status

  • Code changes have been tested against unit tests
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

bdistin added some commits Apr 29, 2019

bdistin added some commits Apr 30, 2019

@bdistin bdistin marked this pull request as ready for review Apr 30, 2019

@SpaceEEC SpaceEEC merged commit 00c4098 into discordjs:master Jul 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.