Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to kick members from VoiceChannels and remove duplicated methods #3242

Merged
merged 6 commits into from May 4, 2019

Conversation

Projects
None yet
3 participants
@amishshah
Copy link
Member

commented Apr 30, 2019

Please describe the changes this PR makes and why it should be merged:
Please see discordapp/discord-api-docs#933.

  • Allows members to be kicked from voice channels
  • Adds VoiceState#setChannel
  • Improves reliability of using voiceState.connection
  • Removes duplicated methods on GuildMember
    • member.setDeaf => member.voice.setDeaf
    • member.setMute => member.voice.setMute
    • member.setVoiceChannel => member.voice.setChannel

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

amishshah added some commits Apr 30, 2019

remove duplicated methods across GuildMember and VoiceState
member.setDeaf => member.voice.setDeaf
member.setMute => member.voice.setMute
member.setVoiceChannel => member.voice.setChannel

@amishshah amishshah changed the title Add ability to kick members from VoiceChannels Add ability to kick members from VoiceChannels and remove duplicated methods Apr 30, 2019

@amishshah amishshah marked this pull request as ready for review May 4, 2019

@bdistin

bdistin approved these changes May 4, 2019

Copy link
Member

left a comment

lgtm

@amishshah amishshah merged commit e64773e into discordjs:master May 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@amishshah amishshah deleted the amishshah:voice-kick branch May 4, 2019

SpaceEEC added a commit to SpaceEEC/discord.js that referenced this pull request May 4, 2019

@SpaceEEC SpaceEEC referenced this pull request May 4, 2019

Merged

feat(GuildMember): add support for voice kicking #3246

3 of 5 tasks complete

SpaceEEC added a commit that referenced this pull request May 6, 2019

rasmusgerdin added a commit to RTByte/RTByte that referenced this pull request May 6, 2019

Update vckick to use new voice kick function, lang updates
This commit updates the vckick command to use the new voice kick function introduced in discordapp/discord-api-docs#933 and discordjs/discord.js#3242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.