Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Guild.voiceStates To Typings And JSDocs #3294

Merged
merged 4 commits into from Jul 4, 2019

Conversation

Projects
None yet
3 participants
@Skillz4Killz
Copy link
Contributor

commented May 24, 2019

Please describe the changes this PR makes and why it should be merged:
This PR adds .voiceStates to typings and to the JSDocs

image

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Skillz4Killz added some commits May 24, 2019

@Skillz4Killz Skillz4Killz changed the title Add Guild.voiceStates To Typings Add Guild.voiceStates To Typings And JSDocs May 24, 2019

@amishshah

This comment has been minimized.

Copy link
Member

commented May 30, 2019

Might be worth documenting VoiceStateStore to show that it is a DataStore as well as adding it to typings

@Skillz4Killz

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2019

I am not really proficient enough in the music features of D.JS. In fact, this problem was found because I was deleting voice stuff from the bots cache. I would need some detailed guidance on how you wish the PR would go, please or maybe just have that in a separate PR.

@Skillz4Killz

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2019

Bump. Wondering what I can do to get this merged I still have that silly ts-ignore which id like to remove please. 🙏

@SpaceEEC
Copy link
Member

left a comment

good to go now

@SpaceEEC SpaceEEC merged commit 20d7b3d into discordjs:master Jul 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Koyamie added a commit to Koyamie/discord.js that referenced this pull request Jul 5, 2019

Merge pull request #87 from discordjs/master
docs/typings(VoiceStateStore): document and type the class (discordjs#3294)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.