Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): backport documentation for Presence #3315

Merged
merged 5 commits into from Jun 1, 2019

Conversation

Projects
None yet
2 participants
@PyroTechniac
Copy link
Contributor

commented Jun 1, 2019

Please describe the changes this PR makes and why it should be merged:
Backports Presence#clientStatus documentation from master.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
@SpaceEEC
Copy link
Member

left a comment

Could you also backport the ClientPresenceStatus typedef from #3208?
So offline is not valid in this context, as it isn't.

Show resolved Hide resolved src/structures/Presence.js Outdated

PyroTechniac and others added some commits Jun 1, 2019

capitalize o
Co-Authored-By: SpaceEEC <spaceeec@yahoo.com>
@PyroTechniac

This comment has been minimized.

Copy link
Contributor Author

commented Jun 1, 2019

Could you also backport the ClientPresenceStatus typedef from #3208?
So offline is not valid in this context, as it isn't.

done!

Show resolved Hide resolved src/structures/Presence.js Outdated

@SpaceEEC SpaceEEC merged commit 0c61019 into discordjs:11.5-dev Jun 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PyroTechniac PyroTechniac deleted the PyroTechniac:patch-1 branch Jun 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.