Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for premium guilds #3316

Merged
merged 6 commits into from Jun 5, 2019

Conversation

Projects
None yet
7 participants
@izexi
Copy link
Contributor

commented Jun 2, 2019

see discordapp/discord-api-docs@3d8cca0

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
@NCPlayz

This comment has been minimized.

Copy link

commented Jun 2, 2019

You might want to add the emoji object's available field which is related to premium guilds too. Fairly self-explanatory, but could be worth the wait for the docs to clarify.

Show resolved Hide resolved src/structures/GuildEmoji.js Outdated
@bdistin

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

Isn't there also a nitro or boost message type to add?

@almostSouji

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

https://discordapp.com/developers/docs/resources/channel#message-object-message-types

USER_PREMIUM_GUILD_SUBSCRIPTION | 8
USER_PREMIUM_GUILD_SUBSCRIPTION_TIER_1 | 9
USER_PREMIUM_GUILD_SUBSCRIPTION_TIER_2 | 10
USER_PREMIUM_GUILD_SUBSCRIPTION_TIER_3 | 11

what should also be noted though:

Please note that this feature is currently under experimentation, and these fields may be subject to change.

source: https://github.com/discordapp/discord-api-docs/blob/master/docs/Change_Log.md

@bdistin

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

Oh, sure, yeah I missed that. Apologies. 👍

@Kolkies

This comment has been minimized.

Copy link

commented Jun 5, 2019

Boosting released yesterday

@izexi izexi referenced this pull request Jun 5, 2019

Closed

Update MessageTypes #3330

@SpaceEEC SpaceEEC merged commit c877580 into discordjs:master Jun 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@izexi izexi deleted the izexi:premium-guilds branch Jun 5, 2019

SpaceEEC added a commit to SpaceEEC/discord.js that referenced this pull request Jun 6, 2019

SpaceEEC added a commit to SpaceEEC/discord.js that referenced this pull request Jun 6, 2019

@SpaceEEC SpaceEEC referenced this pull request Jun 6, 2019

Merged

feat(Guild): backport support for premium/boosting #3332

3 of 5 tasks complete

SpaceEEC added a commit that referenced this pull request Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.