Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setRolePositions function #3317

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
None yet
3 participants
@brxxn
Copy link
Contributor

commented Jun 2, 2019

Please describe the changes this PR makes and why it should be merged:
This pull request allows for role positions to be batch-updated similar to how channel positions are. It uses the Discord API endpoint PATCH /guild/:id/roles. It is a pull request to add the enhancement mentioned in issue #3280.

Status

  • Code changes have been tested against the Discord API, or there are no code changes (note: I don't have the time at the moment to test this, and I would prefer someone else test.)
  • I know how to update typings and have done so, or typings don't need updating (note: I can update typings, but I would prefer someone else do it so that I don't mess anything up, as this is my first contribution to this library.)

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
[rest] add setRolePositions function
Allows for role positions to be batch-updated similar to how channel
positions are. It uses the Discord API endpoint PATCH /guild/:id/roles

@SpaceEEC SpaceEEC merged commit 8bc8ffe into discordjs:master Jun 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

SpaceEEC added a commit that referenced this pull request Jun 5, 2019

@Slydelix

This comment has been minimized.

Copy link

commented Jun 6, 2019

It would make a bit more sense if the function was in RoleStore but I guess it's fine with where it is 😄

SpaceEEC added a commit to SpaceEEC/discord.js that referenced this pull request Jun 8, 2019

SpaceEEC added a commit to SpaceEEC/discord.js that referenced this pull request Jun 8, 2019

@SpaceEEC SpaceEEC referenced this pull request Jun 8, 2019

Merged

feat(Guild): backport misc properties and setRolePositions #3337

3 of 5 tasks complete

SpaceEEC added a commit that referenced this pull request Jun 13, 2019

feat(Guild): backport misc properties and setRolePositions (#3337)
* feat(Guild): backport misc properties and setRolePositions

PRs:
* #3168
* #3317

* typings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.