Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Abort Requests that takes a lot of time to resolve #3327

Open
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@Deivu
Copy link
Contributor

commented Jun 5, 2019

Please describe the changes this PR makes and why it should be merged:
Lately I suffered from some requests that gets too long to resolve, and due to this, our bot slowed down a lot, as well causing us some problems specially in some of our modules. By adding a request timeout feature for Discord.js requests, we can make sure that requests that takes too long to resolve could get cancelled, hence solving the problem of requests that takes an inconsiderable amount of time to resolve.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Deivu added some commits Jun 4, 2019

Show resolved Hide resolved src/rest/APIRequest.js Outdated
Show resolved Hide resolved src/rest/APIRequest.js Outdated
@Deivu

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2019

Updated as per reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.