Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Guild): backport support for premium/boosting #3332

Merged
merged 2 commits into from Jun 13, 2019

Conversation

Projects
None yet
2 participants
@SpaceEEC
Copy link
Member

commented Jun 6, 2019

Please describe the changes this PR makes and why it should be merged:

This PR backports support for premium (or boosted) guilds.
Adding:

  • Emoji#available
  • Guild#premiumTier
  • Guild#premiumSubscriptionCount
  • GuildMember#premiumSinceTimestamp (also premiumSince getter)
  • The four new message types
    • USER_PREMIUM_GUILD_SUBSCRIPTION
    • USER_PREMIUM_GUILD_SUBSCRIPTION_TIER_1
    • USER_PREMIUM_GUILD_SUBSCRIPTION_TIER_2
    • USER_PREMIUM_GUILD_SUBSCRIPTION_TIER_3

PR: #3316 (Commit: c877580)

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
@TheLearneer

This comment has been minimized.

Copy link

commented Jun 6, 2019

I am not so sure, but isn't the animated guild icon also supposed to be included in this PR ??

Just asked it cuz I havent seen any other PR or discussions related to it, and also cause the animated guild icon was released with the boosting release.

EDIT: Just realized its a PR for backport support, but still a thought.

@SpaceEEC SpaceEEC merged commit b892436 into discordjs:11.5-dev Jun 13, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@SpaceEEC SpaceEEC deleted the SpaceEEC:feat/guild_boosting branch Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.