Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Guild): backport misc properties and setRolePositions #3337

Merged
merged 2 commits into from Jun 13, 2019

Conversation

Projects
None yet
2 participants
@SpaceEEC
Copy link
Member

commented Jun 8, 2019

Please describe the changes this PR makes and why it should be merged:

This PR backports:

  • Several properties of Guild from #3168
    • banner and the bannerURL getter
    • description
    • embedChannelID
    • maximumMembers
    • maximumPresences
    • widgetEnabled
    • widgetChannelID
    • vanityURLCode
    • fetch method
  • Guild#setRolePositions from #3317

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

SpaceEEC added some commits Jun 8, 2019

@reetou

This comment has been minimized.

Copy link

commented Jun 11, 2019

Since Discord introduced boosting servers and giving them banners for specific level this PR is a killer-feature for now and very wanted. Hope it will be merged soon.

@SpaceEEC SpaceEEC merged commit e6a378b into discordjs:11.5-dev Jun 13, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@SpaceEEC SpaceEEC deleted the SpaceEEC:feat/backports branch Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.