Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Guild): default iconURL to gif if animated #3338

Merged
merged 3 commits into from Jun 13, 2019

Conversation

Projects
None yet
1 participant
@SpaceEEC
Copy link
Member

commented Jun 8, 2019

Please describe the changes this PR makes and why it should be merged:

This PR changes Guild#iconURL to default to a gif extension for animated guild icons.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

SpaceEEC added some commits Jun 8, 2019

@SpaceEEC SpaceEEC merged commit 1bec28b into discordjs:master Jun 13, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@SpaceEEC SpaceEEC deleted the SpaceEEC:feat/guild_animated_icon branch Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.