Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Role): throw TypeError in comparePositionTo #3466

Merged

Conversation

@SpaceEEC
Copy link
Member

commented Sep 9, 2019

Please describe the changes this PR makes and why it should be merged:

Role#comparePositionTo will reject with a type error when an invalid RoleResolvable is passed. However this is a synchronous method and should throw instead.
This PR takes care of that.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
@iCrawl
iCrawl approved these changes Sep 10, 2019

@iCrawl iCrawl merged commit 8e0f525 into discordjs:master Sep 10, 2019

3 checks passed

ESLint
Details
TSLint
Details
Documentation
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.