Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typings(GuildChannel): add members getter #3467

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@SpaceEEC
Copy link
Member

commented Sep 10, 2019

Please describe the changes this PR makes and why it should be merged:

Closes #3445 as the head repository was deleted, leaving the PR in an unfixable state.
(Can't apply requested changes nor run required checks)

The original PR moved the members getter to GuildChannel where it is actually defined:

get members() {
const members = new Collection();
for (const member of this.guild.members.values()) {
if (this.permissionsFor(member).has('VIEW_CHANNEL', false)) {
members.set(member.id, member);
}
}
return members;
}

This PR now also removes the now redundant declarations in deriving classes and runs the checks.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@SpaceEEC SpaceEEC added the t: typings label Sep 10, 2019

@iCrawl
iCrawl approved these changes Sep 10, 2019

@iCrawl iCrawl merged commit 4072ffb into discordjs:master Sep 10, 2019

3 checks passed

ESLint
Details
TSLint
Details
Documentation
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.