Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Partials): add DMChannel/MessageReaction#fetch() and PartialTypes.REACTION #3474

Merged
merged 15 commits into from Jan 5, 2020

Conversation

@izexi
Copy link
Contributor

izexi commented Sep 18, 2019

#3261 but without the bug

As reimu mentioned, Action#getReaction() looks for existing reactions on a message which doesn't work with newly added reactions. dd4c7c3 fixes that by calling ReactionStore#add() which was how it was done before.

Due to the change above and the fact that the _patch method was being called for existing reactions, it resulted in the count being set back to 0. To handle this d2744e8 will make it so that the count will only be updated through patching when it hasn't been set or when the MessageReaction is partial.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
izexi and others added 13 commits May 9, 2019
Co-Authored-By: Vlad Frangu <kingdgrizzle@gmail.com>
Co-Authored-By: Antonio Román <kyradiscord@gmail.com>
@izexi izexi mentioned this pull request Oct 14, 2019
2 of 5 tasks complete
Copy link
Contributor

Monbrey left a comment

Looks good

@izexi izexi force-pushed the izexi:partials-and-stuff branch from 75f90d1 to 9f5a8eb Dec 11, 2019
@iCrawl
iCrawl approved these changes Dec 25, 2019
@ShadowRanger

This comment has been minimized.

Copy link

ShadowRanger commented Jan 5, 2020

Any updates on having this merged? Having a lot of problems with DMChannels with partials, and this would address these bugs. Thanks in advance.

@SpaceEEC SpaceEEC merged commit 6af0da1 into discordjs:master Jan 5, 2020
3 checks passed
3 checks passed
ESLint ESLint
Details
TSLint
Details
Documentation
Details
@izexi izexi mentioned this pull request Jan 5, 2020
@izexi izexi deleted the izexi:partials-and-stuff branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.