Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Channel): Default channel type incorrectly set #3496

Merged
merged 1 commit into from Oct 1, 2019

Conversation

@Monbrey
Copy link
Contributor

commented Oct 1, 2019

When creating a channel without specifying the type option, the default was set to text instead of using the ChannelTypes enum constants.

This was throwing a Discord API error.

Issue identified by Ashley#0911

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
@SpaceEEC SpaceEEC merged commit a03e439 into discordjs:master Oct 1, 2019
3 checks passed
3 checks passed
ESLint
Details
TSLint
Details
Documentation
Details
SpaceEEC added a commit that referenced this pull request Oct 1, 2019
Backports #3496 (a03e439) to the 11.5-dev branch
@Monbrey Monbrey deleted the Monbrey:channel-type-default branch Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.