Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GuildMember): filter out duplicate roles when updating #3502

Open
wants to merge 1 commit into
base: 11.5-dev
from

Conversation

@SpaceEEC
Copy link
Member

commented Oct 1, 2019

Please describe the changes this PR makes and why it should be merged:

This PR filters out duplicated duplicated roles when patching a GuildMember.

The intend behind this is to apply this to GuildMember#addRoles where an error occurs when one is trying to add a role which is already there.

That behavior would be identical to the behaviour of addRole, removeRole, and removeRoles then.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.