Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typings: optional reason for setNSFW and add deleted properties #3505

Merged
merged 2 commits into from Oct 4, 2019

Conversation

@SpaceEEC
Copy link
Member

commented Oct 1, 2019

Please describe the changes this PR makes and why it should be merged:

Fixes #3494

This PR adds the missing deleted properties and makes reason optional in TextChannel#setNSFW as mentioned in #3494.

Also makes Guild#setDefaultMessageNotifications' reason parameter optional.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
@SpaceEEC SpaceEEC added the t: typings label Oct 1, 2019
Copy link
Contributor

left a comment

Same thing applies on the reason param for Guild#setDefaultMessageNotifications() 👀

public setDefaultMessageNotifications(defaultMessageNotifications: DefaultMessageNotifications, reason: string): Promise<Guild>;

@SpaceEEC

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2019

Added that to the PR. 👍

@SpaceEEC SpaceEEC merged commit a8e3657 into discordjs:11.5-dev Oct 4, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@SpaceEEC SpaceEEC deleted the SpaceEEC:typings/deleted_set_reason branch Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.