Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make arraysEqual avoid mutating the input arrays #3506

Merged
merged 1 commit into from Oct 4, 2019

Conversation

@rei2hu
Copy link
Contributor

commented Oct 1, 2019

Please describe the changes this PR makes and why it should be merged:

Targetting 11.5-dev

This method causes bugs where it is used because it mutates the array.

  1. Comparing guilds with Guild#equals may mutate the guild features array causing it to be inaccurate. (fixed for master in #2544)
  2. Comparing GuildMember._roles with each other may mutate the underlying roles array which causes the oldMember parameter for the guildMemberUpdate event to have inaccurate roles.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
@SpaceEEC SpaceEEC merged commit 8ddd061 into discordjs:11.5-dev Oct 4, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.