Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typings: GuildChannel#parentID is nullable #3508

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@almostSouji
Copy link
Member

commented Oct 1, 2019

Please describe the changes this PR makes and why it should be merged:

According to both discord.js and discord API docs GuildChannel#parentID is marked as nullable. This PR adapts the typings to reflect this behavior.
ref: https://discordapp.com/developers/docs/resources/channel#channel-object
ref: https://discord.js.org/#/docs/main/master/class/GuildChannel?scrollTo=parentID

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
@kyranet
kyranet approved these changes Oct 1, 2019
@SpaceEEC SpaceEEC merged commit e936f07 into discordjs:master Oct 2, 2019
3 checks passed
3 checks passed
ESLint
Details
TSLint
Details
Documentation
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.