Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typings: GuildChannel#parent and #parentID are nullable #3509

Merged

Conversation

@almostSouji
Copy link
Member

commented Oct 1, 2019

Please describe the changes this PR makes and why it should be merged:

Target: 11.5-dev

According to both discord.js and discord API docs GuildChannel#parentID as well as GuildChannel#parent are marked as nullable. This PR adapts the typings to reflect this behavior and as such acts as backport and addition to #3508.
ref: https://discordapp.com/developers/docs/resources/channel#channel-object
ref: https://discord.js.org/#/docs/main/master/class/GuildChannel?scrollTo=parentID

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
@SpaceEEC SpaceEEC added the t: typings label Oct 1, 2019
@kyranet
kyranet approved these changes Oct 1, 2019
@SpaceEEC SpaceEEC merged commit 2a78b00 into discordjs:11.5-dev Oct 2, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.