Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Consider messages deleted if their channel is deleted #3519
Please describe the changes this PR makes and why it should be merged:
Message#deleted as well as Message#deletable currently return false/true if the messages channel is deleted. Since our users use these properties to check if a message can be deleted before doing so this can lead to unexpected behavior.
If the channel is deleted the API will respond with an error since the respective endpoint is unavailable.
This PR attempts to change this behavior by setting messages deleted on channel_delete.
The deletable getter will automatically carry the changes, since it checks
I see no need to update typings, might have missed something though.
Semantic versioning classification: