Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: Add deprecation warning related to uws #3648

Merged
merged 3 commits into from Jan 12, 2020

Conversation

@vladfrangu
Copy link
Contributor

vladfrangu commented Dec 27, 2019

Please describe the changes this PR makes and why it should be merged:

As uws support was removed from master, it is good to give the users of 11.x a heads up
This mimics what require('util').deprecate does to an extent

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
vladfrangu added 2 commits Dec 27, 2019
@SpaceEEC SpaceEEC added this to In progress in v11 via automation Jan 12, 2020
@SpaceEEC SpaceEEC merged commit 5556b05 into discordjs:11.5-dev Jan 12, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
v11 automation moved this from In progress to Done Jan 12, 2020
@amishshah amishshah moved this from Done to To do in v11 Jan 13, 2020
@SpaceEEC SpaceEEC moved this from To do to Done in v11 Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v11
  
Done
3 participants
You can’t perform that action at this time.