Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typings(GuildEmoji): make url not-nullable #3656

Merged
merged 2 commits into from Jan 4, 2020
Merged

Conversation

@Jyguy
Copy link
Contributor

Jyguy commented Jan 1, 2020

Please describe the changes this PR makes and why it should be merged:
Since Emoji.url is only available for custom emotes, it would make sense to have GuildEmoji.url not nullable because it is guaranteed to be a custom emote.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
Jyguy added 2 commits Jan 1, 2020
@SpaceEEC SpaceEEC merged commit 155b682 into discordjs:master Jan 4, 2020
3 checks passed
3 checks passed
ESLint ESLint
Details
TSLint
Details
Documentation
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.