Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ShardingManager#options.shardList to typings #3657

Merged
merged 1 commit into from Jan 3, 2020

Conversation

@cloudrac3r
Copy link
Contributor

cloudrac3r commented Jan 3, 2020

Please describe the changes this PR makes and why it should be merged:

options.shardList is present in code here:

* @param {string|number[]} [options.shardList='auto'] List of shards to spawn or "auto"

options.shardList is absent in typings here:

constructor(file: string, options?: {

I have fixed this problem by adding shardList to typings.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
@kyranet
kyranet approved these changes Jan 3, 2020
@SpaceEEC SpaceEEC added the t: typings label Jan 3, 2020
@SpaceEEC SpaceEEC merged commit c734979 into discordjs:master Jan 3, 2020
3 checks passed
3 checks passed
ESLint ESLint
Details
TSLint
Details
Documentation
Details
Koyamie added a commit to Koyamie/discord.js that referenced this pull request Jan 4, 2020
typings(ShardingManager): add options.shardList (discordjs#3657)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.