Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement caching of members from message data #3684

Merged
merged 11 commits into from Jan 19, 2020

Conversation

@Monbrey
Copy link
Contributor

Monbrey commented Jan 12, 2020

Also changes Message#member to a getter as per current v12 src

https://github.com/discordjs/discord.js/projects/5#card-31519290
https://github.com/discordjs/discord.js/projects/5#card-31518970

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
@SpaceEEC SpaceEEC added this to In progress in v11 via automation Jan 13, 2020
src/structures/Message.js Outdated Show resolved Hide resolved
src/structures/Message.js Outdated Show resolved Hide resolved
src/structures/MessageMentions.js Outdated Show resolved Hide resolved
src/structures/Message.js Show resolved Hide resolved
src/structures/Message.js Outdated Show resolved Hide resolved
src/structures/MessageMentions.js Outdated Show resolved Hide resolved
@SpaceEEC SpaceEEC self-requested a review Jan 14, 2020
src/structures/MessageMentions.js Outdated Show resolved Hide resolved
src/structures/Message.js Outdated Show resolved Hide resolved
Monbrey and others added 4 commits Jan 18, 2020
Co-Authored-By: SpaceEEC <spaceeec@yahoo.com>
Discord does not send an id in the member data here
@SpaceEEC SpaceEEC merged commit 0f49d67 into discordjs:11.5-dev Jan 19, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
v11 automation moved this from In progress to Done Jan 19, 2020
@Monbrey Monbrey deleted the Monbrey:11.5-memberCaching branch Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v11
  
Done
2 participants
You can’t perform that action at this time.