Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Presence): Add info tag to ActivityType regarding custom status #3757

Merged
merged 1 commit into from Feb 12, 2020

Conversation

@RDambrosio016
Copy link
Contributor

RDambrosio016 commented Feb 1, 2020

Please describe the changes this PR makes and why it should be merged:
This pr adds an info tag explaining that CUSTOM_STATUS is only for custom statuses received from users and that bots cannot set them, as currently setActivity states the activity's type can be any of ActivityType

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
@RDambrosio016 RDambrosio016 mentioned this pull request Feb 1, 2020
3 of 5 tasks complete
@RDambrosio016 RDambrosio016 changed the title Add info tag to ActivityType regarding custom status feat(Presence): Add info tag to ActivityType regarding custom status Feb 1, 2020
@SpaceEEC SpaceEEC merged commit 3f8ea38 into discordjs:master Feb 12, 2020
3 checks passed
3 checks passed
ESLint
Details
TSLint
Details
Documentation
Details
@advaith1

This comment has been minimized.

Copy link

advaith1 commented Feb 15, 2020

@RDambrosio016 technically bots can send the CUSTOM_STATUS activity type (and it will say "custom status" on its full profile), however, Discord has not yet enabled the state and emoji fields for bots so bots can't actually set the text.

@RDambrosio016

This comment has been minimized.

Copy link
Contributor Author

RDambrosio016 commented Feb 15, 2020

Yes but even if bots could set it, as long as the discord api docs dont document it, discord.js wont implement it.

@RDambrosio016 RDambrosio016 deleted the RDambrosio016:add_info_tag branch Feb 15, 2020
@advaith1

This comment has been minimized.

Copy link

advaith1 commented Feb 15, 2020

You already can set it in discord.js, there's no checking for that, and it is documented in the api docs. The only issue is that Discord has not gotten around to enabling the state and emoji fields for bots, which is also documented.

@tipakA

This comment has been minimized.

Copy link
Contributor

tipakA commented Feb 15, 2020

Setting custom status per definition means you set it to something. Since D.js has no check for this type, there can be a need for explanation why doesn't it set anything except bot having empty custom status, despite it being documented both in D.js and in Discord's documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.