Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BitField): add BitField base class #3759

Merged
merged 2 commits into from Feb 12, 2020
Merged

Conversation

@SpaceEEC
Copy link
Member

SpaceEEC commented Feb 1, 2020

Please describe the changes this PR makes and why it should be merged:

This PR backports #2765 in a non-breaking manner. (No ActivityFlags or Speaking sadly)

Overview:

  • Actually document Game#flags (has already been in the typings for quite some time)
  • Document ActivityType typedef ( ^ )
  • Add BitField
  • Inherit from BitField in Permissions
  • Hard-deprecate Permissions#raw (emitting an event on access)
  • Fix documentation and definition of deprecated Permissions#member

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
@SpaceEEC SpaceEEC added this to In progress in v11 via automation Feb 1, 2020
Copy link
Contributor

PlayTheFallen left a comment

One small request on deprecation side of things.

src/util/Permissions.js Outdated Show resolved Hide resolved
@SpaceEEC SpaceEEC merged commit 46e8bc4 into discordjs:11.5-dev Feb 12, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
v11 automation moved this from In progress to Done Feb 12, 2020
@SpaceEEC SpaceEEC deleted the SpaceEEC:feat/bitfield branch Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v11
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.