Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Permissions): Add VIEW_GUILD_INSIGHTS #3928

Merged
merged 1 commit into from Mar 17, 2020
Merged

Conversation

@Khaazz
Copy link
Contributor

Khaazz commented Mar 11, 2020

Please describe the changes this PR makes and why it should be merged:
This PR adds the VIEW_GUILD_INSIGHTS permissions as documented in discord/discord-api-docs#1421

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
@iCrawl
iCrawl approved these changes Mar 14, 2020
@SpaceEEC

This comment has been minimized.

Copy link
Member

SpaceEEC commented Mar 14, 2020

I'd wait with merging this PR until the upstream PR was merged, to avoid having a permission alias in case Discord decides to rename it (again).

(It previously appeared under the name VIEW_SERVER_ANALYTICS in the past already for a short amount of time)

@advaith1

This comment has been minimized.

Copy link
Contributor

advaith1 commented Mar 17, 2020

@SpaceEEC upstream PR has been merged

@amishshah

This comment has been minimized.

Copy link
Member

amishshah commented Mar 17, 2020

Upstream has been merged, so merging this PR

@amishshah amishshah merged commit 5b9cdc5 into discordjs:master Mar 17, 2020
3 checks passed
3 checks passed
ESLint
Details
TSLint
Details
Documentation
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.