Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Adding two examples #265
I agree with you in the former, code style needs some changes.
I believe this addresses the concerns.
With respect to the comments about code style, I am not quite sure what the two of you mean.
The code could be far more explicit with
I'll also note that now the console.log returns assuming plurality of roles changed (which I forgot because setRoles is a thing), and will stay as such for single role changes. One could make a size check and adjust the sentence accordingly, but this seems like more noise than is necessary for such an example.
almostSouji left a comment
Logs are okay, plurality is also fine.
Thanks for addressing my earlier concerns so quickly