Skip to content

Only call activity_pub_after_publish on local activity objects #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pmusaraj merged 1 commit into from
Jun 2, 2023
Merged

Only call activity_pub_after_publish on local activity objects #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/discourse_activity_pub_activity.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def after_deliver
published_at = Time.now.utc.iso8601
self.update(published_at: published_at)

if self.object.model&.respond_to?(:activity_pub_after_publish)
if self.object.local && self.object.model&.respond_to?(:activity_pub_after_publish)
args = {}
args[:published_at] = published_at if create?
args[:deleted_at] = published_at if delete?
Expand Down
10 changes: 10 additions & 0 deletions spec/models/discourse_activity_pub_activity_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,5 +188,15 @@
delete_activity.after_deliver
end
end

context "with accept activity" do
let(:accept_activity) { Fabricate(:discourse_activity_pub_activity_accept, actor: actor) }

it "works" do
freeze_time
accept_activity.after_deliver
expect(accept_activity.published_at.to_i).to eq_time(Time.now.utc.to_i)
end
end
end
end