This repository was archived by the owner on Jul 22, 2025. It is now read-only.
DEV: Prevent detect_text_locale from appearing in menus
#967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### 🔍 Overview With the recent changes to allow DiscourseAi in the translator plugin, `detect_text_locale` was needed as a CompletionPrompt. However, it is leaking into composer/post helper menus. This PR ensures we don't not show it in those menus.
xfalcox
approved these changes
Nov 27, 2024
Member
|
I think it is fine, but we should have some sort of test for this stuff, even just on the server. Then as we add / change options we will not be in for a surprise. I think it is worth a followup PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Overview
With the recent changes to allow Discourse AI in the translator plugin (#946),
detect_text_localewas needed as aCompletionPrompt. However, it is leaking into composer/post helper menus. This PR ensures we don't not show it in those menus.📸 Screenshots
Before
After