Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Freezed time used in update_holiday_usernames_spec.rb should be UTC #3

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@lis2
Copy link
Contributor

commented Sep 11, 2019

I was curious why this spec was failing on my local machine.

The reason for that was from_date of the post which in this spec was 2018-06-05 10:20:00 UTC

Because I am in Australia timezone, freeze_time Time.new(2018, 6, 5, 18, 40) was giving me 2018-06-05 08:40:00 UTC which was before from_date.

I think that bug was introduced here: b1fe445#diff-b1651fed94990b46f84a76daf7330e2dL17

@SamSaffron

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

Oh I see, this makes sense! we have lots of people very very close to UTC.

@SamSaffron SamSaffron merged commit 7682a80 into discourse:master Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.