Fix topic link color in dark mode #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dark blue link color is not very readable on dark background https://meta.discourse.org/t/sams-personal-minimal-topic-list-design/23552/335?u=alex_p
|
@hnb-ku is this good to merge? |
I think we should also do the same for dark schemes. I understand the contrast issue, but let's brighten the color instead of using $primary. I suggest using Here's a before/after of the contrast
|
|
Yeah, seems ok. |
|
Great, thanks @AlexP11223 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shown here, dark blue link color is not very readable on dark background.
So this PR adds a custom property in
color_definitionsswitching to the color scheme primary color when in dark mode.We should keep the original color in light mode because it was one of the features of this theme.