Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Update deprecated methods in Rails 6.0.0 #1

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@lis2
Copy link
Contributor

commented Sep 11, 2019

This fix is to solve two warnings about deprecated methods in Rails 6.0.0:
DEPRECATION WARNING: ActionView::Base instances must implement compiled_method_container or use the class method with_empty_template_cache for constructing an ActionView::Base instances that has an empty cache.
DEPRECATION WARNING: ActionView::Base instances should be constructed with a lookup context, assignments, and a controller.

I don't feel super confident about that, even if specs are still green and without warning

@SamSaffron

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

probably best to apply this, lets merge it in and see what happens.

@SamSaffron SamSaffron merged commit a44beab into discourse:master Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.