Skip to content
Permalink
Browse files

UX: Show installed version with SHA instead of number of commits

Removes the "+ 437" string at the end of "v2.4.0.beta2 + 437",
and adds a link to the exact commit on github underneath.
  • Loading branch information...
nlalonde committed Sep 10, 2019
1 parent bd930a9 commit 509e61e2722862eae22d51b1e97a4288816b2047
@@ -5,7 +5,10 @@

<div class="version-number">
<h4>{{i18n 'admin.dashboard.installed_version'}}</h4>
<h3><a href={{versionCheck.gitLink}} target="_blank">{{dash-if-empty versionCheck.installed_describe}}</a></h3>
<h3>{{dash-if-empty versionCheck.installed_version}}</h3>
<div class="sha-link">
(<a href={{versionCheck.gitLink}} target="_blank">{{versionCheck.shortSha}}</a>)
</div>
</div>

{{#if versionCheck.noCheckPerformed}}
@@ -626,10 +626,13 @@
flex: 1 0 auto;
white-space: nowrap;
}
h4 {
h4, .sha-link {
font-size: $font-down-2;
margin-bottom: 0;
}
.sha-link {
font-weight: normal;
}
}
.version-status {
display: flex;

1 comment on commit 509e61e

@discoursebot

This comment has been minimized.

Copy link

commented on 509e61e Sep 10, 2019

This commit has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/why-dashboard-updates-dont-look-right/127655/13

Please sign in to comment.
You can’t perform that action at this time.