Skip to content
Browse files
DEV: correct heisentest testing for avatars
If for some reason we created andupload with id 1 in the test then the
test would fail. This can happen if this is the absolute first test to
run on the db.

Fix sets the upload to a legitimate which in turn means the last upload
will not be upload id 1 and stops using id hard coding for the testing.
  • Loading branch information
SamSaffron committed Feb 1, 2019
1 parent bbaa3e9 commit a84aaf197a4d2767b85e76cb2a9d06aaab944747
Showing with 10 additions and 4 deletions.
  1. +10 −4 spec/models/user_avatar_spec.rb
@@ -125,8 +125,10 @@

it 'can leave gravatar alone' do
user = Fabricate(:user, uploaded_avatar_id: 1)
user.user_avatar.update_columns(gravatar_upload_id: 1)
upload = Fabricate(:upload)

user = Fabricate(:user, uploaded_avatar_id:

stub_request(:get, "")
.to_return(status: 200, body: file_from_fixtures("logo.png"), headers: {})
@@ -138,8 +140,12 @@ change { Upload.count }.by(1)

expect(user.uploaded_avatar_id).to eq(1)
expect(user.user_avatar.custom_upload_id).to eq(
expect(user.uploaded_avatar_id).to eq(

last_id =

expect(last_id).not_to eq(
expect(user.user_avatar.custom_upload_id).to eq(last_id)

describe 'when avatar url returns an invalid status code' do

0 comments on commit a84aaf1

Please sign in to comment.