Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
FEATURE: Add site setting to show more detailed 404 errors. (#8014)
If the setting is turned on, then the user will receive information about the subject: if it was deleted or requires some special access to a group (only if the group is public). Otherwise, the user will receive a generic #404 error message. For now, this change affects only the topics and categories controller. This commit also tries to refactor some of the code related to error handling. To make error pages more consistent (design-wise), the actual error page will be rendered server-side.
- Loading branch information
Showing
23 changed files
with
755 additions
and
646 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,32 +1,36 @@ | ||
<div class="container"> | ||
{{discourse-banner user=currentUser banner=site.banner}} | ||
</div> | ||
|
||
<div class="list-controls"> | ||
{{#if errorHtml}} | ||
{{{errorHtml}}} | ||
{{else}} | ||
<div class="container"> | ||
{{outlet "navigation-bar"}} | ||
{{discourse-banner user=currentUser banner=site.banner}} | ||
</div> | ||
</div> | ||
|
||
{{conditional-loading-spinner condition=loading}} | ||
<div class="list-controls"> | ||
<div class="container"> | ||
{{outlet "navigation-bar"}} | ||
</div> | ||
</div> | ||
|
||
<div class="container list-container {{if loading "hidden"}}"> | ||
<div class="row"> | ||
<div class="full-width"> | ||
<div id="header-list-area"> | ||
{{outlet "header-list-container"}} | ||
{{conditional-loading-spinner condition=loading}} | ||
|
||
<div class="container list-container {{if loading "hidden"}}"> | ||
<div class="row"> | ||
<div class="full-width"> | ||
<div id="header-list-area"> | ||
{{outlet "header-list-container"}} | ||
</div> | ||
</div> | ||
</div> | ||
</div> | ||
<div class="row"> | ||
<div class="full-width"> | ||
<div id="list-area"> | ||
{{plugin-outlet name="discovery-list-container-top" | ||
args=(hash category=category listLoading=loading)}} | ||
{{outlet "list-container"}} | ||
<div class="row"> | ||
<div class="full-width"> | ||
<div id="list-area"> | ||
{{plugin-outlet name="discovery-list-container-top" | ||
args=(hash category=category listLoading=loading)}} | ||
{{outlet "list-container"}} | ||
</div> | ||
</div> | ||
</div> | ||
</div> | ||
</div> | ||
|
||
{{plugin-outlet name="discovery-below"}} | ||
{{plugin-outlet name="discovery-below"}} | ||
{{/if}} |
Oops, something went wrong.
fdb1d34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/you-need-to-request-membership-but-im-already-a-member/128502/5