Skip to content
Tree: 2cb805a683
Commits on Nov 2, 2019
  1. FIX: TopicQuery doesn't react well to subcategories without definitions

    danielwaterworth committed Nov 1, 2019
    Move includes call higher which makes it possible to run all of the
    intermediate queries for easier debugging.
    Add tests for TagsController with categories in the path.
Commits on Nov 1, 2019
  1. FEATURE: Create New Topic button on embed with params (#8280)

    markvanlan committed Nov 1, 2019
    * FEATURE: Create New Topic button on embed with params
  2. FIX: Linting

    eviltrout committed Nov 1, 2019
  3. FIX: Move `makeArray` to discourse-common

    eviltrout committed Nov 1, 2019
  4. FIX: Missing `run` import

    eviltrout committed Nov 1, 2019
  5. REFACTOR: Split off raw handlebars helpers from compiler

    eviltrout committed Nov 1, 2019
    This allows us to compile without Ember being present
  6. Remove debug info

    eviltrout committed Nov 1, 2019
  7. DEV: Reduce duplication

    danielwaterworth committed Nov 1, 2019
  8. DEV: Switch flaky blame to restorer_spec.rb

    danielwaterworth committed Nov 1, 2019
  9. DEV: Mark flaky test

    danielwaterworth committed Nov 1, 2019
  10. DEV: More prefabrication

    danielwaterworth committed Nov 1, 2019
  11. FIX: Do not load plugin CSS/JS assets when disabled (#8275)

    davidtaylorhq committed Nov 1, 2019
    Follow-up to 839916a and 5bd6b70
  12. DEV: correct fragile test

    SamSaffron committed Nov 1, 2019
    This test would fail sometimes if for some reason topic id 1 was in the db
    No reason to pretend here, this only makes for a fragile test suite.
  13. DEV: allow positioning of nav items and allow selection

    SamSaffron committed Nov 1, 2019
    Previously we could not place extra nav items in a particular order.
    This change introduces a new `before` attribute to addNavigationBarItem
    with this attribute we can place a nav item before "top" or any other place.
    Additionally this allows navigation items to force active state. In some
    cases we may want an items that is simply a "filter" on latest using `?query_params`
    when we do that we can "force" the filter active.
    A concrete example is the assign plugin that adds a nav item for
    Unassigned => `/c/cat-slug/l/latest?assigned=nobody&status=open`
    If we did not force then latest would be selected even though the filter
    is clicked.
  14. PERF: add a filtered index for banners

    SamSaffron committed Nov 1, 2019
    This ensures we can very quickly figure out which topics are banners if
    a banner is set.
    Previously you would have to scan an entire table to find banners
Commits on Oct 31, 2019
  1. FIX: Unread topics not clearing when whisper is last post (#8271)

    martin-brennan committed Oct 31, 2019
    Meta thread:
    * when sending a whisper, the highest_staff_post_number is set
    in the next_post_number method for a Topic, but the
    highest_post_number is left alone. this leaves a situation
    where highest_staff_post_number is > highest_post_number
    * when TopicsBulkAction#dismiss_posts was run, it was only setting the topic_user
    highest_seen_post_number using the highest_post_number from the topic, so if
    the user was staff and the last post in a topic was a whisper
    their highest seen number was not set, and the topic stayed unread
    Found through testing that the bug wasn't to do with Assign/Unassign as they do not affect the post numbers, only whispering does.
  2. FIX: Hide muted subcategories for mobile (#8273)

    lis2 committed Oct 31, 2019
    That bug was mentioned in [meta](
    Fix was done in that PR #8239
    however I forgot about mobile template
  3. FIX: Enter key on forms submits rather than refresh (#8274)

    markvanlan committed Oct 31, 2019
    Both for forgot password form, and confirm password for second factor
  4. FEATURE: categories can require topics have a tag from a tag group

    nlalonde committed Oct 30, 2019
    In a category's settings, the Tags tab has two new fields to
    specify the number of tags that must be added to a topic
    from a tag group. When creating a new topic, an error will be
    shown to the user if the requirement isn't met.
  5. DEV: Add plugin outlets to advanced search options

    pmusaraj committed Oct 31, 2019
    Also adds classes for the filter containers, allowing for more granular styling.
  6. FIX: make notification consent banner usable via keyboard and screenr…

    LeoMcA authored and eviltrout committed Oct 31, 2019
    …eader (#8255)
    * update d-button to support btn-link class
    * add display attribute to d-button rather than computing on class
  7. DEV: Server-side category routing changes

    danielwaterworth committed Oct 30, 2019
    The routes for categories are changing. The scheme that I intend to move
    us to is:
    This commit adds support for the new scheme to the server side without
    dropping support for existing URLs. It is necessary to support existing
    URLs for two reasons:
     * This commit does not change any client side routing code,
     * Posts that contain category hashtags that refer to a root category
       are baked into URLs that do not fit this new scheme, (/c/[id]-[slug])
  8. Copy edit: rename profile header to profile background

    awesomerobot committed Oct 31, 2019
  9. DEV: Remove pretty_text import hack & still work server-side (#8266)

    markvanlan committed Oct 31, 2019
    * FIX: move attachment_css_class constant out of upload-short-url for discourse-markdown-it
    * Use setTimeout instead of ember later
    * WIP. Not sure if this worked.
    * oneboxer cache in separate file
    * Reset onebox cache still
    * set functions for oneboxers cache
  10. FIX: Cache `Discourse.system_user` separately for each multisite tena…

    davidtaylorhq committed Oct 31, 2019
    …nt (#8276)
    This was not causing any known issue, because the system user ID is always the same across all sites. However, we should cache this on a per-site basis to be safe.
  11. DEV: Cleanup misspelled TextHelper param

    pmusaraj committed Oct 31, 2019
You can’t perform that action at this time.