Skip to content
Permalink
Tree: 58b5d1434b
Commits on Nov 13, 2019
  1. FIX: Allow forceActive without a customHref

    danielwaterworth committed Nov 13, 2019
  2. DEV: No need to use call to call these callbacks

    danielwaterworth committed Nov 13, 2019
    This is safe because addNavigationBarItem decorates these callbacks,
    throwing away the context.
  3. FIX: do not strip nil string

    techAPJ committed Nov 13, 2019
  4. DEV: Temporarily remove NoChdir cop

    davidtaylorhq committed Nov 13, 2019
    We inherit this rubocop config from plugins and other projects, so the `require` line does not work reliably.
  5. DEV: Remove use of `cd` in the app (#8337)

    davidtaylorhq committed Nov 13, 2019
    `FileUtils.cd` and `Dir.chdir` cause the working directory to change for the entire process. We run sidekiq jobs, hijacked requests and deferred jobs in threads, which can make working directory changes have unintended side-effects.
    
    - Add a rubocop rule to warn about usage of Dir.chdir and FileUtils.cd
    - Added rubocop:disable for scripts used outside the app
    - Refactored code using cd to use alternative methods
    - Temporarily skipped the rubocop check for lib/backup_restore. This will require more complex refactoring, so I will create a separate PR for review
  6. DEV: provides a way to hook into createWidget constructor (#8340)

    jjaffeux committed Nov 13, 2019
  7. DEV: call destroy() on widget when glue is cleaned up (#8338)

    jjaffeux committed Nov 13, 2019
  8. Add plugin outlet after flagged post bodies

    featheredtoast committed Nov 13, 2019
Commits on Nov 12, 2019
  1. UX: Add CSP documentation link to content_security_policy_script_src …

    tshenry committed Nov 12, 2019
    …setting
  2. REFACTOR: redo DiscourseTagging.filter_allowed_tags (#8328)

    nlalonde committed Nov 12, 2019
    This method had grown into a monster. Its query had bugs
    that I couldn't fix, and new features would be hard to add.
    Also I don't understand how it all works anymore...
    Replace it with common table expressions that can be queried
    to generate the results we need, instead of subtracting
    results using lots of "NOT IN" clauses.
    
    Fixed are bugs with tag schemas that use combinations of
    tag groups, parent tags, and one-tag-per-topic restrictions.
    For example: https://meta.discourse.org/t/130991/6
  3. DEV: Provide a nicer error when JSON is malformed

    eviltrout committed Nov 12, 2019
    This is very useful for development. It will give a much nicer error if
    the JSON that comes back from the server is missing a required key.
  4. DEV: Let is not supported, use var instead

    romanrizzi committed Nov 12, 2019
  5. FIX: Do not deactivate admin accounts with recent posts or api keys (#…

    davidtaylorhq committed Nov 12, 2019
    …8342)
    
    This prevents 'bot' users being deactivated
  6. DEV: Deprecation warning for aliased module usage (#8341)

    markvanlan committed Nov 12, 2019
  7. UX: Do not add leading/trailing spaces when copying API key in Firefox

    davidtaylorhq committed Nov 12, 2019
    If there is any other whitespace in the container, then Firefox will add a leading/trailing space when double clicking the key. This commit wraps the key in a div with no whitespace, to work around the problem.
  8. REFACTOR: Remove a few `Discourse.Site` globals

    eviltrout committed Nov 12, 2019
  9. DEV: Remove RSS feed polling in favor of plugin (#8233)

    markvanlan committed Nov 12, 2019
  10. REFACTOR: Don't generate `Discourse` constants for mixins

    eviltrout committed Nov 12, 2019
  11. FIX: Update quotes after moving posts (#8326)

    udan11 committed Nov 12, 2019
  12. FIX: Topic lists filtered by tag and a specified filter don't work

    danielwaterworth committed Nov 12, 2019
    This was a regression caused by 59241df
  13. DEV: Run prettier

    CvX committed Nov 12, 2019
  14. DEV: Run prettier

    CvX committed Nov 12, 2019
  15. DEV: Provide radix argument to parseInt (#8281)

    CvX committed Nov 12, 2019
    * DEV: Provide radix 10 argument to parseInt
    
    * DEV: Provide radix 16 argument to parseInt
    
    * DEV: Remove unnecessary parseInt calls
    
    * Fix year formatting
    
    parseInt was used here to convert decimals to ints
  16. FIX: tag and category watchers regression (#8336)

    lis2 authored and SamSaffron committed Nov 12, 2019
    I made a regression here 17366d3#diff-ddeebb36d131f89ca91be9d04c2baefaR10
    
    When the tag is added, people watching specific tag are notified but also people watching specific category.
    
    Therefore, `notify_post_users` should accept options who should be notified.
    
    So when `category` is added to the topic, users watching topic and users watching category are notified.
    
    When `tag` is added to the topic, users watching topic and users watching tag are notified
    
    Finally, when a new post is created, everybody is notified, topic watchers, category watchers, tag watchers.
Commits on Nov 11, 2019
  1. FIX: Better error handling for invalid locale bundle versions

    gschlager committed Nov 11, 2019
  2. FIX: In case `@ember/object` hasn't been loaded yet

    eviltrout committed Nov 11, 2019
  3. REFACTOR: Remove `debounce` to `discourseDebounce`

    eviltrout committed Nov 11, 2019
    Otherwise it can be confused with the ember debounce
  4. REFACTOR: Remove `discourse/lib/throttle`

    eviltrout committed Nov 11, 2019
  5. DEV: Removed needless indirection

    danielwaterworth committed Nov 11, 2019
    An artifact of when tagging was a plugin no doubt.
Older
You can’t perform that action at this time.