Skip to content
Branch: master
Commits on Dec 3, 2019
  1. FIX: Call the right method

    udan11 committed Dec 3, 2019
Commits on Dec 2, 2019
  1. FIX: Do not autocomplete categories or emojis in code blocks (#8433)

    udan11 committed Dec 2, 2019
    Emojis and category autocomplete show up often when writing code
    snippets, which makes it easy to insert unwanted text by mistake.
Commits on Nov 29, 2019
  1. FIX: Optimize quoted images (#8427)

    udan11 committed Nov 29, 2019
    Only images that were part of a lightbox used to be optimized. This
    patch ensures that quoted images are also optimized.
Commits on Nov 27, 2019
  1. FIX: Correctly resize lazy loaded images in Oneboxes

    udan11 committed Nov 27, 2019
Commits on Nov 25, 2019
  1. DEV: Add test for load-more (#8369)

    udan11 committed Nov 25, 2019
    Follow-up to 3650c64.
  2. FIX: Show quoted images correctly. (#8391)

    udan11 committed Nov 25, 2019
    This commit attempts to fix two issues that affect quoted images.
    The first issue is observed while loading. The 'position: absolute' CSS
    property makes 'width' and 'height' behave differently. Instead of using
    the known image size, this makes it use the computed width and height of
    the image, which should be the right size, as shown to the user.
    The second issue is caused by 'object-fit: cover' property which trimmed
    the left and right sides of wide pictures to make them fit inside the
  3. DEV: Replace magic values (#8398)

    udan11 committed Nov 25, 2019
    Follow-up to 35942f7.
  4. DEV: Add test to ensure :after_auth event is triggered (#8400)

    udan11 committed Nov 25, 2019
    Follow-up to ee8669d.
  5. DEV: Add test for opening drafts from Activity screen (#8401)

    udan11 committed Nov 25, 2019
    Follow-up to 520d54d.
Commits on Nov 20, 2019
  1. FIX: Use correct MIME type for theme exports (#8379)

    udan11 committed Nov 20, 2019
Commits on Nov 18, 2019
  1. FIX: Ensure load-more considers current position (#8357)

    udan11 committed Nov 18, 2019
    The loadMore action was not called if user was already at the bottom
    of the page.
  2. FIX: Better handling of Group model state (#8356)

    udan11 committed Nov 18, 2019
    The group card and group members page were affecting each other and were
    leaking members list and the query parameters which led to bad UX
    experience and sub-optimal performance (client made more queries because
    it was loading fewer members).
    This commit refactors the group model to make it more consistent, remove
    dead code, move error handling outside of model.
  3. FIX: A pmOnly tag should link to messages (#8361)

    udan11 authored and SamSaffron committed Nov 18, 2019
    isPrivateMessages represents that the tag list is shown in the context
    of private messages and pmOnly represents that the tag is used only in
    private messages.
Commits on Nov 12, 2019
  1. FIX: Update quotes after moving posts (#8326)

    udan11 committed Nov 12, 2019
Commits on Nov 11, 2019
  1. FIX: Do not skip some emails in user search (#8317)

    udan11 committed Nov 11, 2019
    It used to skip the email addresses containing the plus sign.
  2. FIX: Keep emoji images in group bio excerpt (#8329)

    udan11 committed Nov 11, 2019
Commits on Nov 8, 2019
  1. DEV: Update chrome-launcher (#8318)

    udan11 committed Nov 8, 2019
    This version is compatible with macOS Catalina
Commits on Oct 26, 2019
  1. FIX: Reload plugin translations in development (#8243)

    udan11 committed Oct 26, 2019
    The default locale is :en_US, which is just a thin layer over :en. In
    other words, :en_US has the :en locale as a fallback. When "en.yml" is
    edited, only the :en locale is refreshed and :en_US becomes stale.
    This commit ensures that there is a dependency on the fallback locales
Commits on Oct 23, 2019
  1. PERF: Add index on group to category_groups (#8231)

    udan11 authored and davidtaylorhq committed Oct 23, 2019
  2. PERF: Add unique index oauth2_user_infos(user_id, provider) (#8230)

    udan11 authored and davidtaylorhq committed Oct 23, 2019
Commits on Oct 21, 2019
  1. DEV: Add test.

    udan11 committed Oct 21, 2019
    Follow-up to 2f54dd5.
  2. FIX: Load user model when some attributes are missing.

    udan11 committed Oct 21, 2019
    Follow-up to 3ad07aa.
  3. FIX: Reload only notifications when refreshing notification count (#8221

    udan11 committed Oct 21, 2019
    Previously, we used to reload the whole User instance which discarded
    any changes made (for example setting 'unstage' to false).
  4. FIX: Zeitwerk-related fixes for jobs. (#8219)

    udan11 committed Oct 21, 2019
Commits on Oct 14, 2019
  1. FIX: Zeitwerk-related fixes for jobs. (#8187)

    udan11 committed Oct 14, 2019
  2. DEV: Fix heisentest (ensure that user ID really does not exist).

    udan11 committed Oct 14, 2019
  3. FIX: Ensure that scheduled jobs are loaded. (#8183)

    udan11 committed Oct 14, 2019
    In development, the scheduled jobs are loaded lazily and MiniScheduler
    cannot discover them (/sidekiq/scheduler does not show any jobs).
Commits on Oct 8, 2019
  1. FEATURE: Add site setting to show more detailed 404 errors. (#8014)

    udan11 committed Oct 8, 2019
    If the setting is turned on, then the user will receive information
    about the subject: if it was deleted or requires some special access to
    a group (only if the group is public). Otherwise, the user will receive
    a generic #404 error message. For now, this change affects only the
    topics and categories controller.
    This commit also tries to refactor some of the code related to error
    handling. To make error pages more consistent (design-wise), the actual
    error page will be rendered server-side.
Commits on Sep 16, 2019
  1. FIX: Open drafts for PMs from Activity > Drafts screen.

    udan11 committed Sep 16, 2019
    Draft.get sometimes returns only the sequence number.
Commits on Sep 11, 2019
  1. UX: Use medium format for displaying time in post notices. (#8074)

    udan11 committed Sep 11, 2019
Commits on Aug 22, 2019
  1. FIX: Do not set destination_url cookie after deleting own account. (#…

    udan11 authored and ZogStriP committed Aug 22, 2019
    destination_url cookie is used to redirect the user to the a private
    page after they have logged in. After deleting own account, a user's
    pages would be refreshed which would set the destination_url, cookie
    that can cause a redirect to an invalid page after logging in again.
    Reproduction steps:
    1. User is at `/u/:username/preferences/account` and deletes account by
    requesting DELETE `/u/:username.json`.
    2. User is being destroyed and a MessageBus message (`file-change`,
    `['refresh']`) is published.
    3. User receives response to DELETE request, but page may be or not
    refreshed. Anyway, since they can no longer see the preferences page,
    they are redirected to `/login` and `destination_url` cookie is set,
    that will redirect on next login (but to the previous preferences page).
Commits on Aug 19, 2019
  1. UX: Hide "Create Tag" option if user cannot create tag. (#7723)

    udan11 committed Aug 19, 2019
Commits on Aug 16, 2019
  1. DEV: User simulator tried to modify frozen string.

    udan11 committed Aug 16, 2019
  2. FIX: J/K navigation resets current selection when scrolling fast.

    udan11 committed Aug 16, 2019
    Sometimes, when keeping J or K pressed and scrolling fast, the current
    selection would go out of the viewport for a few moments and the
    algorithm would try selecting the "best" element that is in viewport.
    This bug is reproducible only on certain machines. For example, Linux
    machines seem to be passing key events faster to the browser.
You can’t perform that action at this time.