Comparing changes
Open a pull request
| @@ -0,0 +1,21 @@ | ||
| +languages: | ||
| + Ruby: true | ||
| + JavaScript: true | ||
| + Python: false | ||
| + PHP: false | ||
| + | ||
| +exclude_paths: | ||
| + - "app/assets/javascripts/defer/*" | ||
| + - "app/assets/javascripts/ember-addons/*" | ||
| + - "lib/autospec/*" | ||
| + - "lib/es6_module_transpiler/*" | ||
| + - "lib/highlight_js/*" | ||
| + - "lib/import/*" | ||
| + - "lib/javascripts/*" | ||
| + - "lib/tasks/*" | ||
| + - "lib/*.js" | ||
| + - "public/*" | ||
| + - "script/*" | ||
| + - "spec/*" | ||
| + - "test/*" | ||
| + - "vendor/*" |
| @@ -0,0 +1,17 @@ | ||
| +app/assets/javascripts/env.js | ||
| +app/assets/javascripts/main_include_admin.js | ||
| +app/assets/javascripts/vendor.js | ||
| +app/assets/javascripts/locales/i18n.js | ||
| +app/assets/javascripts/ember-addons/ | ||
| +app/assets/javascripts/discourse/lib/autosize.js.es6 | ||
| +lib/javascripts/locale/ | ||
| +lib/javascripts/messageformat.js | ||
| +lib/javascripts/moment.js | ||
| +lib/javascripts/moment_locale/ | ||
| +lib/highlight_js/ | ||
| +plugins/**/lib/javascripts/locale | ||
| +public/javascripts/ | ||
| +vendor/ | ||
| +test/javascripts/test_helper.js | ||
| +test/javascripts/fixtures | ||
| +test/javascripts/helpers/assertions.js |
| @@ -0,0 +1,107 @@ | ||
| +{ | ||
| + "env": { | ||
| + "jasmine": true, | ||
| + "node": true, | ||
| + "mocha": true, | ||
| + "browser": true, | ||
| + "builtin": true | ||
| + }, | ||
| + "parserOptions": { | ||
| + "ecmaVersion": 7, | ||
| + "sourceType": "module" | ||
| + }, | ||
| + "globals": | ||
| + {"Ember":true, | ||
| + "jQuery":true, | ||
| + "$":true, | ||
| + "QUnit":true, | ||
| + "RSVP":true, | ||
| + "Discourse":true, | ||
| + "Em":true, | ||
| + "Handlebars":true, | ||
| + "I18n":true, | ||
| + "bootbox":true, | ||
| + "moduleFor":true, | ||
| + "moduleForComponent":true, | ||
| + "Pretender":true, | ||
| + "sandbox":true, | ||
| + "controllerFor":true, | ||
| + "test":true, | ||
| + "visit":true, | ||
| + "andThen":true, | ||
| + "click":true, | ||
| + "currentPath":true, | ||
| + "currentRouteName":true, | ||
| + "currentURL":true, | ||
| + "fillIn":true, | ||
| + "keyEvent":true, | ||
| + "triggerEvent":true, | ||
| + "count":true, | ||
| + "exists":true, | ||
| + "visible":true, | ||
| + "invisible":true, | ||
| + "asyncRender":true, | ||
| + "selectKit":true, | ||
| + "expandSelectKit":true, | ||
| + "collapseSelectKit":true, | ||
| + "selectKitSelectRowByValue":true, | ||
| + "selectKitSelectRowByName":true, | ||
| + "selectKitSelectRowByIndex":true, | ||
| + "selectKitSelectNoneRow":true, | ||
| + "selectKitFillInFilter":true, | ||
| + "asyncTestDiscourse":true, | ||
| + "fixture":true, | ||
| + "find":true, | ||
| + "sinon":true, | ||
| + "moment":true, | ||
| + "_":true, | ||
| + "alert":true, | ||
| + "define":true, | ||
| + "require":true, | ||
| + "requirejs":true, | ||
| + "hasModule":true, | ||
| + "Blob":true, | ||
| + "File":true}, | ||
| + "rules": { | ||
| + "block-scoped-var": 2, | ||
| + "dot-notation": 0, | ||
| + "eqeqeq": [ | ||
| + 2, | ||
| + "allow-null" | ||
| + ], | ||
| + "guard-for-in": 2, | ||
| + "no-bitwise": 2, | ||
| + "no-caller": 2, | ||
| + "no-cond-assign": 0, | ||
| + "no-debugger": 2, | ||
| + "no-empty": 0, | ||
| + "no-eval": 2, | ||
| + "no-extend-native": 2, | ||
| + "no-extra-parens": 0, | ||
| + "no-inner-declarations": 2, | ||
| + "no-irregular-whitespace": 2, | ||
| + "no-iterator": 2, | ||
| + "no-loop-func": 2, | ||
| + "no-multi-str": 2, | ||
| + "no-new": 2, | ||
| + "no-plusplus": 0, | ||
| + "no-proto": 2, | ||
| + "no-script-url": 2, | ||
| + "no-sequences": 2, | ||
| + "no-shadow": 2, | ||
| + "no-undef": 2, | ||
| + "no-unused-vars": 2, | ||
| + "no-with": 2, | ||
| + "no-this-before-super": 2, | ||
| + "semi": 2, | ||
| + "strict": 0, | ||
| + "valid-typeof": 2, | ||
| + "wrap-iife": [ | ||
| + 2, | ||
| + "inside" | ||
| + ], | ||
| + "no-mixed-spaces-and-tabs": 2, | ||
| + "no-trailing-spaces": 2 | ||
| + }, | ||
| + "parser": "babel-eslint" | ||
| +} |
| @@ -1,22 +0,0 @@ | ||
| -app/assets/javascripts/env.js | ||
| -app/assets/javascripts/main_include.js | ||
| -app/assets/javascripts/main_include_admin.js | ||
| -app/assets/javascripts/preload_store.js | ||
| -app/assets/javascripts/pagedown_custom.js | ||
| -app/assets/javascripts/vendor.js | ||
| -app/assets/javascripts/locales/i18n.js | ||
| -app/assets/javascripts/defer/html-sanitizer-bundle.js | ||
| -app/assets/javascripts/discourse/lib/Markdown.Editor.js | ||
| -jsapp/lib/Markdown.Editor.js | ||
| -lib/javascripts/locale/ | ||
| -lib/javascripts/messageformat.js | ||
| -lib/javascripts/moment.js | ||
| -lib/javascripts/moment_locale/ | ||
| -lib/es6_module_transpiler/support/es6-module-transpiler.js | ||
| -public/javascripts/ | ||
| -spec/phantom_js/smoke_test.js | ||
| -vendor/ | ||
| -test/javascripts/helpers/ | ||
| -test/javascripts/test_helper.js | ||
| -test/javascripts/test_helper.js | ||
| - |
| @@ -1,83 +0,0 @@ | ||
| -{ | ||
| - "predef":["Ember", | ||
| - "jQuery", | ||
| - "$", | ||
| - "RSVP", | ||
| - "Discourse", | ||
| - "$LAB", | ||
| - "Em", | ||
| - "PreloadStore", | ||
| - "Handlebars", | ||
| - "I18n", | ||
| - "bootbox", | ||
| - "module", | ||
| - "moduleFor", | ||
| - "moduleForComponent", | ||
| - "Pretender", | ||
| - "sandbox", | ||
| - "integration", | ||
| - "controllerFor", | ||
| - "test", | ||
| - "ok", | ||
| - "not", | ||
| - "expect", | ||
| - "equal", | ||
| - "blank", | ||
| - "present", | ||
| - "visit", | ||
| - "andThen", | ||
| - "click", | ||
| - "currentPath", | ||
| - "currentRouteName", | ||
| - "currentURL", | ||
| - "fillIn", | ||
| - "keyEvent", | ||
| - "triggerEvent", | ||
| - "count", | ||
| - "exists", | ||
| - "asyncTestDiscourse", | ||
| - "fixture", | ||
| - "find", | ||
| - "sinon", | ||
| - "moment", | ||
| - "start", | ||
| - "_", | ||
| - "alert", | ||
| - "containsInstance", | ||
| - "parseHTML", | ||
| - "deepEqual", | ||
| - "notEqual", | ||
| - "require", | ||
| - "requirejs", | ||
| - "hasModule", | ||
| - "Blob", | ||
| - "File"], | ||
| - "node" : false, | ||
| - "browser" : true, | ||
| - "boss" : true, | ||
| - "curly": false, | ||
| - "debug": false, | ||
| - "devel": false, | ||
| - "eqeqeq": true, | ||
| - "evil": true, | ||
| - "forin": false, | ||
| - "immed": false, | ||
| - "laxbreak": false, | ||
| - "newcap": true, | ||
| - "noarg": true, | ||
| - "noempty": false, | ||
| - "nonew": false, | ||
| - "nomen": false, | ||
| - "onevar": false, | ||
| - "plusplus": false, | ||
| - "regexp": false, | ||
| - "undef": true, | ||
| - "unused": true, | ||
| - "sub": true, | ||
| - "strict": false, | ||
| - "white": false, | ||
| - "eqnull": true, | ||
| - "quotmark": false, | ||
| - "lastsemic": true, | ||
| - "esnext": true | ||
| -} |
| @@ -0,0 +1,23 @@ | ||
| +# Use this file to configure the Overcommit hooks you wish to use. This will | ||
| +# extend the default configuration defined in: | ||
| +# https://github.com/brigade/overcommit/blob/master/config/default.yml | ||
| +# | ||
| +# At the topmost level of this YAML file is a key representing type of hook | ||
| +# being run (e.g. pre-commit, commit-msg, etc.). Within each type you can | ||
| +# customize each hook, such as whether to only run it on certain files (via | ||
| +# `include`), whether to only display output if it fails (via `quiet`), etc. | ||
| +# | ||
| +# For a complete list of hooks, see: | ||
| +# https://github.com/brigade/overcommit/tree/master/lib/overcommit/hook | ||
| +# | ||
| +# For a complete list of options that you can use to customize hooks, see: | ||
| +# https://github.com/brigade/overcommit#configuration | ||
| + | ||
| +PreCommit: | ||
| + RuboCop: | ||
| + enabled: true | ||
| + command: ['bundle', 'exec', 'rubocop'] | ||
| + EsLint: | ||
| + enabled: true | ||
| + command: ['eslint', '--ext', '.es6', '-f', 'compact'] | ||
| + include: '**/*.es6' |
Showing you all comments on commits in this comparison.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
commented on 90c0198
Mar 27, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/the-number-of-censored-blocked-words-is-not-shown-correctly/83975/7 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Mar 28, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/namespace-issue-with-the-u-static-routes/83997/3
discoursebot
commented on 03725c7
Mar 28, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/namespace-issue-with-the-u-static-routes/83997/3 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
Shouldn't this be |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
Ditto ^^ |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
Oops thank you! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Mar 28, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/a-translation-be-missing-for-shared-drafts/83998/4
discoursebot
commented on b5da0b5
Mar 28, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/a-translation-be-missing-for-shared-drafts/83998/4 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Mar 28, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/cannot-upload-multiple-font-types-in-theme-uploads/83810/7
discoursebot
commented on fa608f2
Mar 28, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/cannot-upload-multiple-font-types-in-theme-uploads/83810/7 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Mar 28, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/avatars-invisible-after-last-update/84062/5
discoursebot
commented on efedd97
Mar 28, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/avatars-invisible-after-last-update/84062/5 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Mar 28, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
discoursebot
commented on cf3c670
Mar 28, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Mar 29, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/trash-icon-to-discard-an-edit-doesnt-seem-quite-right/84034/5
discoursebot
commented on 6e569e5
Mar 29, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/trash-icon-to-discard-an-edit-doesnt-seem-quite-right/84034/5 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
I think this looks pretty weird personally. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
coding-horror
Mar 29, 2018
Owner
I suggest keeping the discussion on the dev topic, or once it's on meta we can discuss it there. I don't see it on meta yet.
|
I suggest keeping the discussion on the dev topic, or once it's on meta we can discuss it there. I don't see it on meta yet. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Mar 30, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/removed-new-unread-in-the-menu/84236/2
discoursebot
commented on 15945bc
Mar 30, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/removed-new-unread-in-the-menu/84236/2 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 2, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/groups-can-be-given-same-name-as-existing-username/74010/10
discoursebot
commented on 221503c
Apr 2, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/groups-can-be-given-same-name-as-existing-username/74010/10 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
tgxworld
Apr 2, 2018
Owner
@vinothkannans Thanks for looking into the broken build. However, I don't think this fix is correct and I've reverted it in 2498403. We actually want to still validate the username but if the username belongs to the current user but have a different case, the username can still be updated.
Fixed it in 00d879e
|
@vinothkannans Thanks for looking into the broken build. However, I don't think this fix is correct and I've reverted it in 2498403. We actually want to still validate the username but if the username belongs to the current user but have a different case, the username can still be updated. Fixed it in 00d879e |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 2, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/help-us-test-select-kit/74502/133
discoursebot
commented on d54da51
Apr 2, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/help-us-test-select-kit/74502/133 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 2, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/setup-wizard-select-bug/84333/4
discoursebot
commented on d54da51
Apr 2, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/setup-wizard-select-bug/84333/4 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 2, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
discoursebot
commented on 5685b45
Apr 2, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 2, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/cant-add-the-second-tag/84370/3
discoursebot
commented on a828da3
Apr 2, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/cant-add-the-second-tag/84370/3 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 3, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/suppressing-the-word-likes-on-posts/84178/56
discoursebot
commented on 54819d7
Apr 3, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/suppressing-the-word-likes-on-posts/84178/56 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 3, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/how-to-source-a-theme-from-a-private-git-repository/82584/14
discoursebot
commented on f1ef46d
Apr 3, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/how-to-source-a-theme-from-a-private-git-repository/82584/14 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 3, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/unable-to-expand-profile/84350/5
discoursebot
commented on 61812b5
Apr 3, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/unable-to-expand-profile/84350/5 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 3, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/help-us-test-select-kit/74502/138
discoursebot
commented on b1cc368
Apr 3, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/help-us-test-select-kit/74502/138 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 4, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
discoursebot
commented on c36e201
Apr 4, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 5, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/user-still-have-tl4-after-revoke-admin-grants/84576/19
discoursebot
commented on 1075967
Apr 5, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/user-still-have-tl4-after-revoke-admin-grants/84576/19 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 5, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/bingbot-is-default-blacklisted/84620/1
discoursebot
commented on 91a4fee
Apr 5, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/bingbot-is-default-blacklisted/84620/1 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 5, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
discoursebot
commented on f8637ed
Apr 5, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
tgxworld
Apr 5, 2018
Owner
We should test for the exact job in Sidekiq instead of mocking. You can see how we do it for web hooks here
discourse/spec/models/web_hook_spec.rb
Line 195 in cd6a99a
|
We should test for the exact job in Sidekiq instead of mocking. You can see how we do it for web hooks here discourse/spec/models/web_hook_spec.rb Line 195 in cd6a99a |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 6, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/restoring-a-corrupt-file-does-not-roll-back-the-database/84663/4
discoursebot
commented on 5da7c2a
Apr 6, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/restoring-a-corrupt-file-does-not-roll-back-the-database/84663/4 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 6, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/imported-backups-not-appearing/84459/9
discoursebot
commented on e4a9242
Apr 6, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/imported-backups-not-appearing/84459/9 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 6, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/improving-admin-plugins/84585/5
discoursebot
commented on 2ddcdf8
Apr 6, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/improving-admin-plugins/84585/5 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 6, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/improving-admin-plugins/84585/13
discoursebot
commented on 802a327
Apr 6, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/improving-admin-plugins/84585/13 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 6, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
discoursebot
commented on 10dad5d
Apr 6, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
Sweet. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 6, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/group-profile-save-changes-button-doesnt-work/84732/2
discoursebot
commented on e33aef7
Apr 6, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/group-profile-save-changes-button-doesnt-work/84732/2 |
|
Would forEach work here? I'm thinking we should avoid using |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
kuba-orlik
Apr 7, 2018
If we already have a category affected by this issue, will just updating to newest version fix it, or is there something more to be done?
kuba-orlik
commented on c36e201
Apr 7, 2018
|
If we already have a category affected by this issue, will just updating to newest version fix it, or is there something more to be done? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
techAPJ
Apr 8, 2018
Owner
Not exactly, you will need to create a topic in the affected category, trigger the CategoryStats job manually via Sidekiq, and then delete that topic. Now the category counter should be zero and you will be able to delete the category.
If the above doesn't work for you send me a PM on meta and I will walk you through the process of fixing category count via Rails console.
|
Not exactly, you will need to create a topic in the affected category, trigger the If the above doesn't work for you send me a PM on meta and I will walk you through the process of fixing category count via Rails console. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 8, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/date-range-issue-for-posts-and-new-topics-report/84612/3
discoursebot
commented on f5febe5
Apr 8, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/date-range-issue-for-posts-and-new-topics-report/84612/3 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 8, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/email-in-topics-not-under-approvals-control/72057/18
discoursebot
commented on b872058
Apr 8, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/email-in-topics-not-under-approvals-control/72057/18 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 9, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084/18
discoursebot
commented on c82b2dc
Apr 9, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084/18 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
Thanks @gschlager . |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 9, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/notification-to-flagger-s-when-a-flagged-post-is-edited/84166/5
discoursebot
commented on 62aacce
Apr 9, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/notification-to-flagger-s-when-a-flagged-post-is-edited/84166/5 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 9, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/change-in-shortcuts-focus-on-posts/84728/6
discoursebot
commented on 41150fc
Apr 9, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/change-in-shortcuts-focus-on-posts/84728/6 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 9, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
discoursebot
commented on 41150fc
Apr 9, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 9, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/topic-progress-indicator-overlaps-post-controls/84741/6
discoursebot
commented on d19bbfc
Apr 9, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/topic-progress-indicator-overlaps-post-controls/84741/6 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 9, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/advanced-search-page-needs-some-heart/79123/23
discoursebot
commented on bd7100a
Apr 9, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/advanced-search-page-needs-some-heart/79123/23 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 9, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/my-journey-into-a-massive-posts-rebake-job/84816/17
discoursebot
commented on adb9371
Apr 9, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/my-journey-into-a-massive-posts-rebake-job/84816/17 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 9, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/rebuild-html-for-entire-topic/64148/12
discoursebot
commented on adb9371
Apr 9, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/rebuild-html-for-entire-topic/64148/12 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 10, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/admin-group-setting-missing/84934/7
discoursebot
commented on d9d8657
Apr 10, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/admin-group-setting-missing/84934/7 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 10, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/append-tags-not-working/84932/3
discoursebot
commented on 3a86a25
Apr 10, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/append-tags-not-working/84932/3 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 10, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/discourse-chronos-globe-with-meridians-timer-clock/69281/45
discoursebot
commented on 45f6573
Apr 10, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/discourse-chronos-globe-with-meridians-timer-clock/69281/45 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 10, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/android-topic-control-dropdown-activates-keyboard/84219/6
discoursebot
commented on 11c47f5
Apr 10, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/android-topic-control-dropdown-activates-keyboard/84219/6 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 11, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/unable-to-save-changes-to-a-group/84954/6
discoursebot
commented on 9176b25
Apr 11, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/unable-to-save-changes-to-a-group/84954/6 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
Any details on this? At least for productions it seems to work. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 11, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/the-search-this-topic-option-is-missing-on-mobile-view/85029/7
discoursebot
commented on d16c4b0
Apr 11, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/the-search-this-topic-option-is-missing-on-mobile-view/85029/7 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 11, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/add-support-for-theme-settings/78103/18
discoursebot
commented on 19e8f9a
Apr 11, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/add-support-for-theme-settings/78103/18 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 11, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/links-on-separate-lines-end-up-on-the-same-line/83911/7
discoursebot
commented on 3c8b43b
Apr 11, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/links-on-separate-lines-end-up-on-the-same-line/83911/7 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
oops how did that go missing |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 12, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084/28
discoursebot
commented on c0595eb
Apr 12, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084/28 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 12, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/api-topic-post-creation-ordered-by-updated-at-or-created-at/84511/8
discoursebot
commented on cf9965f
Apr 12, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/api-topic-post-creation-ordered-by-updated-at-or-created-at/84511/8 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 12, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/group-name-cant-have-dot-inside/48658/5
discoursebot
commented on a389bae
Apr 12, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/group-name-cant-have-dot-inside/48658/5 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
discoursebot
Apr 12, 2018
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/restoring-backup-from-2-0-0-beta5-disables-discourse/84505/7
discoursebot
commented on 5da7c2a
Apr 12, 2018
|
This commit has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/restoring-backup-from-2-0-0-beta5-disables-discourse/84505/7 |
This commit has been mentioned on Discourse Meta. There might be relevant details there:
https://meta.discourse.org/t/the-number-of-censored-blocked-words-is-not-shown-correctly/83975/7