Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: Add rawTitle property support to modal-tab #10221

Merged
merged 2 commits into from Jul 12, 2020
Merged

DEV: Add rawTitle property support to modal-tab #10221

merged 2 commits into from Jul 12, 2020

Conversation

CvX
Copy link
Contributor

@CvX CvX commented Jul 12, 2020 

const panels = [
  { id: "test1", rawTitle: "Test 1" },
  { id: "test2", rawTitle: "Test 2" }
];

showModal("a-modal", { panels }));

@CvX CvX requested a review from jjaffeux July 12, 2020 12:47
@CvX CvX merged commit 942cc9b into master Jul 12, 2020
@CvX CvX deleted the modal-raw-title branch July 12, 2020 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjaffeux jjaffeux jjaffeux approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@CvX @jjaffeux