Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: set notification levels when added to a group #10378

Merged
merged 2 commits into from Aug 6, 2020

Conversation

nlalonde
Copy link
Member

@nlalonde nlalonde commented Aug 5, 2020

This feature allows admins and group owners to define default
category and tag tracking levels that will be applied to user
preferences automatically at the time when users are added to the
group. Users are free to change those preferences afterwards.
When removed from a group, the user's notification preferences aren't
changed.

This feature allows admins and group owners to define default
category and tag tracking levels that will be applied to user
preferences automatically at the time when users are added to the
group. Users are free to change those preferences afterwards.
When removed from a group, the user's notification preferences aren't
changed.
Copy link
Contributor

@eviltrout eviltrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly looks very nice and solid to me, which is impressive for such a large PR.

I do wonder if we missed an opportunity a long time ago to centralize more of this logic using STI or something, but I suppose that ship has sailed :)

@nlalonde nlalonde merged commit 1ca81fb into master Aug 6, 2020
@nlalonde nlalonde deleted the group-tracking-defaults branch August 6, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants