UX: Timeline should jump to the bottom of the post in single-post topics #10503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eviltrout
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://meta.discourse.org/t/scroll-to-bottom-of-a-topic-with-1-post/161173
Clicking the latest date or dragging the timeline scroller to the bottom in topics with a single lengthy post takes you to the top of that post - even if you're already there.
This PR attempts to address this issue.
The desired result is that topics with a single lengthy post have a slightly different behaviour. When you click on the latest date (or drag the timeline scroller to the very bottom) you should be taken to the bottom of that post.
This is what this PR does.
I've tested this in a number of different scenarios and I haven't seen any regressions in terms of the current functionality. Again, this only affects topics with a single lengthy post.